Skip to content

NO-JIRA: Fix expired test certificate in csr_check_test.go - #287

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
damdo:fix-units-certs-exp
Jan 20, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
damdo:fix-units-certs-exp

Conversation

@damdo

@damdo damdo commented Jan 20, 2026

Copy link
Copy Markdown
Member

The differentCert test certificate expired on 2025-11-18, causing the "successfull fallback to fresh approval from incorrect server cert" test to fail. Regenerated the certificate with CN=test.local and 100-year validity (expires 2125-12-27).

The differentCert test certificate expired on 2025-11-18, causing
the "successfull fallback to fresh approval from incorrect server cert"
test to fail. Regenerated the certificate with CN=test.local and
100-year validity (expires 2125-12-27).
@damdo

damdo commented Jan 20, 2026

Copy link
Copy Markdown
Member Author

/assign @JoelSpeed @theobarberbany

@damdo damdo changed the title Fix expired test certificate in csr_check_test.go NO-JIRA: Fix expired test certificate in csr_check_test.go Jan 20, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 20, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@damdo: This pull request explicitly references no jira issue.

Details

In response to this:

The differentCert test certificate expired on 2025-11-18, causing the "successfull fallback to fresh approval from incorrect server cert" test to fail. Regenerated the certificate with CN=test.local and 100-year validity (expires 2125-12-27).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theobarberbany

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2026

@damdo damdo left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci

openshift-ci Bot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damdo

damdo commented Jan 20, 2026

Copy link
Copy Markdown
Member Author

/verified by units passing again

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2026
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 20, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@damdo: This PR has been marked as verified by units passing again.

Details

In response to this:

/verified by units passing again

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit dcb5f17 into openshift:main Jan 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants